Modify clang declaration weakly-imported query to use Swift's code-gen target triple #81113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artemcm
force-pushed
the
ParameterizeWeakQueryForSwift
branch
from
1e4a388 to
427c0ce
Compare
artemcm
requested review from
jckarter,
hborla,
slavapestov,
xedin,
zoecarver,
egorzhdan,
beccadax,
ian-twilightcoder,
Xazax-hun,
j-hui,
fahadnayyar and
susmonteiro
as code owners
tshortli
reviewed
Apr 28, 2025
artemcm
force-pushed
the
ParameterizeWeakQueryForSwift
branch
from
427c0ce to
dde7fd4
Compare
tshortli
approved these changes
Apr 28, 2025
cachemeifyoucan
approved these changes
Apr 28, 2025
|
swiftlang/llvm-project#10555 |
|
swiftlang/llvm-project#10555 |
|
@swift-ci Please test Apple Silicon |
artemcm
force-pushed
the
ParameterizeWeakQueryForSwift
branch
from
dde7fd4 to
8990cd9
Compare
|
swiftlang/llvm-project#10555 |
…n target triple Similarly to how swiftlang#70564 configures 'ClangImporter's 'CodeGenerator' using Swift's compilation target triple, we must use the versioned version of the 'isWeakImported' query to determine linkage for imported Clang symbols.
artemcm
force-pushed
the
ParameterizeWeakQueryForSwift
branch
from
8990cd9 to
fe632e5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similarly to how #70564 configures 'ClangImporter's 'CodeGenerator' using Swift's compilation target triple, we must use the versioned version of the 'isWeakImported' query to determine linkage for imported Clang symbols.